Fix head requests #105
Closed
Fix head requests #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With newer version of Mojolicious::Plugin::OpenAPI HEAD requests are broken as no spec can be found. Hence the default_spec is used - which requires the 'errors' property. But usually a HEAD request is successful, hence no 'errors' property. This leads to a '500 Internal Server Error' response. A HEAD request is some kind of a GET request (it requests the headers that would be returned if the resource was requested with a GET request. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/HEAD). So the HEAD request should be treated as a special case.
|
Anything I can do? |
|
No. I've been traveling, so haven't found time to look at this yet. I just need to see if I should apply your fix or revert my change. |
|
Ok, I just wanted to ask as you have assigned this PR to me. BTW: Thanks for all your work! |
jhthorsen
pushed a commit
that referenced
this pull request
Feb 14, 2019
- Fix HEAD requests #105 - Fix using /servers/0/url as basePath for OpenAPI v3 #110 Note: This could be breaking change - Fix getting basePath when using under #107 - Add support for "nullable" in OpenAPI 3.0 #106 - Improved handling of Accept header in OpenAPI v3 #104 Can now handle wildcards, such as application/* and */*, even though not defined in the specification. - Bump JSON::Validator to 3.06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an upgrade from version 2.01 to 2.11 I noticed several test failures for HEAD requests in my application. This PR fixes it. A more detailed description is available at reneeb@affb451